rnk marked an inline comment as done.
rnk added inline comments.

================
Comment at: clang/include/clang/Sema/Sema.h:335
 
+  /// A key method to reduce duplicate type info from Sema.
+  virtual void anchor();
----------------
hans wrote:
> I worry that this is going to look obscure to most readers passing through. 
> Maybe it could be expanded to more explicitly spell out that it reduces the 
> size of the debug info?
I want to keep it concise, most readers shouldn't need to know what this is, 
and they can look up technical terms like "key method". I'll say "debug info" 
instead of "type info", though, that should be more obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70340/new/

https://reviews.llvm.org/D70340



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to