efriedma added a comment.

LGTM with a couple nits.



================
Comment at: clang/include/clang/Basic/arm_neon_incl.td:203
 //
 // The modifier 'd' means "default" and does not modify the base type in any
 // way. The available modifiers are given below.
----------------
'd' is gone.


================
Comment at: clang/utils/convert_arm_neon.py:1
+#!/usr/bin/env python3
+
----------------
Are you going to commit this script?  If you are, probably makes sense to 
include some sort of date, so it's clear which change you're talking about, and 
when it makes sense to remove it from the tree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69618/new/

https://reviews.llvm.org/D69618



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to