aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land.
LGTM with one change to DIBuilder inline. ================ Comment at: llvm/include/llvm/IR/DIBuilder.h:243 + unsigned LineNo, DIScope *Context, + Optional<unsigned> AlignInBits); ---------------- This can still be `Optional<unsigned> AlignInBits = {}` to avoid churn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits