nickie marked an inline comment as done.
nickie added a comment.
LGTM, for all that it's worth.
================
Comment at: clang/lib/CodeGen/CGExpr.cpp:1021
void CodeGenModule::EmitExplicitCastExprType(const ExplicitCastExpr *E,
- CodeGenFunction *CGF) {
+ CodeGenFunction *const CGF) {
// Bind VLAs in the cast type.
----------------
I don't think that `const` is necessary here. We're talking about the
function's parameter. Why isn't `E` a `*const` too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70302/new/
https://reviews.llvm.org/D70302
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
