sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/SourceCode.cpp:1133 + Lang != types::TY_INVALID && types::onlyPrecompileType(Lang); + if (!LangOpts) + return IsHeaderFromExtension; ---------------- This structure seems confusing. Why not at the top: ``` if (LangOpts && LangOpts->IsHeaderFile) return true; ``` and then do the extension check and return the result? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
