MadCoder added inline comments.
================ Comment at: clang/lib/Sema/SemaExprObjC.cpp:1129 + } +} + ---------------- rjmccall wrote: > Is this a good idea to do for arbitrary diagnostics? I feel like saying > "direct" in the note when that has nothing to do with the conflict could be a > little misleading. fair enough. some of the mismatches will be because of directness so it can help in that instance but I can see how it's confusing. fixed, and the fact that tests didn't need any updating probably proves you right ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
