MyDeveloperDay added a subscriber: STL_MSFT. MyDeveloperDay added a comment.
I suspect this patch might need a rebase, but I personally don't see anything wrong with it. I think this could really help. I'm pretty sure the Unix line ending requirement is in almost every major style guide (I saw @STL_MSFT mention that they standardize on \r\n too) so I think it meets the criteria. (I know i'll personally use it as I live in a cross-platform shop and users forgetting to configure their Visual Studio is a major pain!) If you're happy to rebase it, I'm happy to review it again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19031/new/ https://reviews.llvm.org/D19031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
