Author: Mark de Wever Date: 2019-11-12T20:50:38+01:00 New Revision: 51abcebbb6e5c8f8befaa523ae873adecf2d1012
URL: https://github.com/llvm/llvm-project/commit/51abcebbb6e5c8f8befaa523ae873adecf2d1012 DIFF: https://github.com/llvm/llvm-project/commit/51abcebbb6e5c8f8befaa523ae873adecf2d1012.diff LOG: [OpenMP] Use an explicit copy in a range-based for The std::pair<const clang::ValueDecl *, llvm::ArrayRef<clang::OMPClauseMappableExprCommon::MappableComponent>> type will be copied in a range-based for loop. Make the copy explicit to avoid the -Wrange-loop-analysis warning. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Differential Revision: https://reviews.llvm.org/D70046 Added: Modified: clang/lib/CodeGen/CGOpenMPRuntime.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp b/clang/lib/CodeGen/CGOpenMPRuntime.cpp index ae881c3e2d7a..cd20cb83afb9 100644 --- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp +++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp @@ -7940,17 +7940,17 @@ class MappableExprsHandler { "Expect a executable directive"); const auto *CurExecDir = CurDir.get<const OMPExecutableDirective *>(); for (const auto *C : CurExecDir->getClausesOfKind<OMPMapClause>()) - for (const auto &L : C->component_lists()) { + for (const auto L : C->component_lists()) { InfoGen(L.first, L.second, C->getMapType(), C->getMapTypeModifiers(), /*ReturnDevicePointer=*/false, C->isImplicit()); } for (const auto *C : CurExecDir->getClausesOfKind<OMPToClause>()) - for (const auto &L : C->component_lists()) { + for (const auto L : C->component_lists()) { InfoGen(L.first, L.second, OMPC_MAP_to, llvm::None, /*ReturnDevicePointer=*/false, C->isImplicit()); } for (const auto *C : CurExecDir->getClausesOfKind<OMPFromClause>()) - for (const auto &L : C->component_lists()) { + for (const auto L : C->component_lists()) { InfoGen(L.first, L.second, OMPC_MAP_from, llvm::None, /*ReturnDevicePointer=*/false, C->isImplicit()); } @@ -7966,7 +7966,7 @@ class MappableExprsHandler { for (const auto *C : CurExecDir->getClausesOfKind<OMPUseDevicePtrClause>()) { - for (const auto &L : C->component_lists()) { + for (const auto L : C->component_lists()) { assert(!L.second.empty() && "Not expecting empty list of components!"); const ValueDecl *VD = L.second.back().getAssociatedDeclaration(); VD = cast<ValueDecl>(VD->getCanonicalDecl()); @@ -8119,7 +8119,7 @@ class MappableExprsHandler { for (const auto *C : CurMapperDir->clauselists()) { const auto *MC = cast<OMPMapClause>(C); - for (const auto &L : MC->component_lists()) { + for (const auto L : MC->component_lists()) { InfoGen(L.first, L.second, MC->getMapType(), MC->getMapTypeModifiers(), /*ReturnDevicePointer=*/false, MC->isImplicit()); } @@ -8288,7 +8288,7 @@ class MappableExprsHandler { "Expect a executable directive"); const auto *CurExecDir = CurDir.get<const OMPExecutableDirective *>(); for (const auto *C : CurExecDir->getClausesOfKind<OMPMapClause>()) { - for (const auto &L : C->decl_component_lists(VD)) { + for (const auto L : C->decl_component_lists(VD)) { assert(L.first == VD && "We got information for the wrong declaration??"); assert(!L.second.empty() && @@ -8441,7 +8441,7 @@ class MappableExprsHandler { // Map other list items in the map clause which are not captured variables // but "declare target link" global variables. for (const auto *C : CurExecDir->getClausesOfKind<OMPMapClause>()) { - for (const auto &L : C->component_lists()) { + for (const auto L : C->component_lists()) { if (!L.first) continue; const auto *VD = dyn_cast<VarDecl>(L.first); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
