xbolva00 marked an inline comment as done. xbolva00 added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:584-587 def err_maybe_falloff_nonvoid_block : Error< "control may reach end of non-void block">; def err_falloff_nonvoid_block : Error< "control reaches end of non-void block">; ---------------- aaron.ballman wrote: > Should we change this wording as well? Along with any other instances of > similar wording (I don't recall if we have something similar for lambdas or > if we defer to the function diagnostics in that case)? +1, I agree. It would be better if somebody more familiar with Obj-C / coroutines and related terminology would improve these text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
