dblaikie added a comment. In D69743#1733101 <https://reviews.llvm.org/D69743#1733101>, @vsk wrote:
> In D69743#1732967 <https://reviews.llvm.org/D69743#1732967>, @dblaikie wrote: > > > What's the extra DWARF that's emitted from the backend? Is there a > > corresponding LLVM code change/test, or is the functionality there but > > dormant in this particular case? (& already running/tested in other cases, > > such as when fn1 is defined in the same CU) > > > The extra DWARF would look like: > > DW_TAG_subprogram > DW_AT_name ("fn1") > DW_AT_declaration (true) > > > This clang change has no corresponding llvm logic change. The functionality > to emit a subprogram for a declaration is already present & tested in llvm, > as is the logic to use such a subprogram to create a TAG_call_site > (llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll is a test, and the > logic is in `DwarfDebug::constructCallSiteEntryDIEs`). That test should cover > the case where a function has no subprogram, though. OK, thanks for the context! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69743/new/ https://reviews.llvm.org/D69743 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
