dblaikie added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3246-3247
DWARFVersion = ExplicitVersion;
}
+ else if (DefaultDWARFVersion != 0)
+ DWARFVersion = DefaultDWARFVersion;
----------------
dblaikie wrote:
> Looks like this should be on a single line to conform to LLVM convention
> (though might just be phabricator doing something weird)
>
> If you can run clang-format over the change (not over the whole file) it
> should fix up issues like this. (there's various clang-format editor
> integrations - there's some google-internal documentation at go/clang-format
> that'll explain how to setup an auto-save hook that'll clang-format the
> changed lines so all your C++ code in the LLVM repository conforms to LLVM's
> coding conventions (well, those that can be expressed by clang-format))
Oh, there's also clang/tools/clang-format/git-clang-format for formatting
anything in a git revision range.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69822/new/
https://reviews.llvm.org/D69822
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
