Anastasia added inline comments.
================
Comment at: lib/Sema/SemaDecl.cpp:5714
@@ +5713,3 @@
+ // OpenCL v2.0 s6.9.b
+ // An image type can only be used as a type of a function argument.
+ if (getLangOpts().OpenCL && R->isImageType()) {
----------------
Move to the line above, separate with -.
================
Comment at: lib/Sema/SemaDecl.cpp:5725
@@ +5724,3 @@
+ // Pipes can only be passed as arguments to a function.
+ if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200 &&
+ R->isPipeType()) {
----------------
Remove 'getLangOpts().OpenCLVersion >= 200'. Parser will only allow pipe for
CL2.0. Ideally we don't need to check getLangOpts().OpenCL either, but might be
good to leave it for documentation purposes.
However could we merge with the previous:
if (getLangOpts().OpenCL) {
if (...) ... // image type
if (...) ... // pipe type
}
================
Comment at: lib/Sema/SemaDecl.cpp:10768
@@ -10746,1 +10767,3 @@
+ // OpenCL v2.0 s6.9b2 - An image type cannot be used to declare a variable, a
+ // structure or union field, an array of images, a pointer to an image, or
the
----------------
Here you only check the pointer and not the other bits. So please modify the
comment according to what the code does.
Does the same restriction apply to other OpenCL types i.e. sampler, event,
queue, etc?
================
Comment at: test/CodeGenOpenCL/opencl_types.cl:39
@@ -38,3 @@
-
-void __attribute__((overloadable)) bad1(image1d_t *b, image2d_t *c, image2d_t
*d) {}
-// CHECK-LABEL:
@{{_Z4bad1P11ocl_image1dP11ocl_image2dS2_|"\\01\?bad1@@\$\$J0YAXPE?APAUocl_image1d@@PE?APAUocl_image2d@@1@Z"}}
----------------
Could you please not remove this mangling test as it's not being tested
elsewhere.
You can remove * from parameters though!
http://reviews.llvm.org/D17437
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
