Charusso added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152
+
+ if (llvm::Error Err = Repls.add(Repl))
+ llvm_unreachable("An error occured during fix-it replacements");
----------------
zinovy.nis wrote:
> Isn't `llvm_unreacheable` too pessimistic? May be use diagnostics instead?
Good idea, thanks! I was too optimistic so `llvm_unreacheable` should never
fire.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69746/new/
https://reviews.llvm.org/D69746
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
