Charusso added a comment.

In D69731#1730899 <https://reviews.llvm.org/D69731#1730899>, @NoQ wrote:

> Clang-Tidy's `PPCallbacks` subsystem looks much more realistic.


I wanted to make it available from the `AnalysisManager` so that I can obtain 
the macro definitions once before the analysis starts. Nor the Clang Tidy's 
`PPCallback`, nor the `AnalysisManager` could retrieve the necessary 
information at that point in the analysis. However, at that point when we 
analyze something all the necessary information is available. Most of the Tidy 
checkers grab their own `PP` reference to use it later on. The Tidy devs agree 
to retrieve such information even in the main `check()` call which going to 
rerun in every `TranslationUnit`. So even it is so primitive, there is no 
better solution as I know. I hope we could find something better / cache it. At 
the moment this code-snippet I have just showed you runs in every `evalCall()`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69731/new/

https://reviews.llvm.org/D69731



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to