[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

[Michael Spencer via Phabricator via cfe-commits]

Bigcheese added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:94
+
+    void printDependencies(std::string &S, StringRef MainFile) {
+      // Sort the modules by name to get a deterministic order.
----------------
kousikk wrote:
> Should output arguments be at the end?
The point was to match up with `MakeDependencyPrinterConsumer`'s 
`printDependencies`. This will also be going away with the patch to merge the 
dependencies.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69420/new/

https://reviews.llvm.org/D69420



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits