Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
When you see
static bool traverseHiddenNodes(
const ExplodedNode *N,
llvm::function_ref<void(const ExplodedNode *)> PreCallback,
llvm::function_ref<void(const ExplodedNode *)> PostCallback,
llvm::function_ref<bool(const ExplodedNode *)> Stop) {
that is 100% will produce errors, as it wants to be so smart. I think it is a
very bad design from the beginning, so it will be still bugprone.
Other than that now every node makes sense, thanks!
================
Comment at: clang/test/Analysis/dump_egraph.c:46
// CHECK: \"pretty\": \"*x\", \"location\": \{ \"line\": 18, \"column\": 10,
\"file\": \"{{(.+)}}dump_egraph.c\" \}
----------------
`\"file\": \"{{(.+)}}dump_egraph.c\" \}` is a cool workaround, but otherwise if
you do not want to end line 32, could you remove this line's ending please?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69150/new/
https://reviews.llvm.org/D69150
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
