aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, assuming the requested test changes are as successful as I expect they
will be (doesn't need additional review if the tests pass).
================
Comment at: clang/test/AST/sourceranges.cpp:155
+
+#if __cplusplus >= 201703L
+ void cpp17() {
----------------
Why is this guarded on C++17? `[[maybe_unused]]` is supported in every language
mode used by this test (it generates a warning, but we're FileCheck'ing so
that's fine -- but you could use `[[deprecated("")]]` instead if you want).
Additionally, I'd appreciate one more test case testing a `__declspec`
attribute as well, to make sure we're handling that properly as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68581/new/
https://reviews.llvm.org/D68581
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
