kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/index/MemIndex.h:72
// A map from (subject, predicate) pair to objects.
- llvm::DenseMap<std::pair<SymbolID, index::SymbolRole>, std::vector<SymbolID>>
+ llvm::DenseMap<std::pair<SymbolID, RelationKind>, std::vector<SymbolID>>
Relations;
----------------
can we rather use `uint8_t` in here instead of `RelationKind` to get rid of the
`DenseMapInfo` specialization completely?
================
Comment at: clang-tools-extra/clangd/index/Relation.h:22
+enum class RelationKind : uint8_t {
+ BaseOf,
----------------
is this clang-formatted ?
================
Comment at: clang-tools-extra/clangd/index/Serialization.h:88
-enum class RelationKind : uint8_t { BaseOf };
-RelationKind symbolRoleToRelationKind(index::SymbolRole);
-index::SymbolRole relationKindToSymbolRole(RelationKind);
----------------
could you also delete definitions of these two functions?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68981/new/
https://reviews.llvm.org/D68981
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
