alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
I agree that the test/clang-tidy directory has become hard to navigate. Splitting tests for checks and for infrastructure seems reasonable to me. I personally don't care about specific directory names and file moves/renames are also not a concern, since git is rather good at handling those. I personally strongly prefer long-term improvements over desire to minimize churn. My only concern is that the add_new_check.py script is updated to put new tests to the right place - totally fine for a follow up though. One more thing is that having all checker tests in one directory is still not particularly nice, but the alternatives I thought of are not clearly superior: 0. test/clang-tidy/modernize-blah-blah.cpp - current state 1. test/clang-tidy/checkers/modernize-blah-blah.cpp - this patch 2. test/clang-tidy/checkers/modernize/blah-blah.cpp - test names don't have the check name substring, which makes them slightly harder to find with eyes 3. test/clang-tidy/checkers/modernize/modernize-blah-blah.cpp - a bit tautological, even longer full file names I'm fine with any of 1-3, since there's no clear winner among the three options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68807/new/ https://reviews.llvm.org/D68807 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
