nridge added a comment.

Ok, I updated the patch to convey the line highlight separately from the token 
highlights.

I did use the simplified approach I mentioned, where I use a single 
`isInactive` flag. If you'd prefer the more general approach where we send an 
array of line styles, I can do that, though my personal preference would be to 
wait until we have an actual use case before generalizing.

There are still no tests yet, as I'm still not sure whether we have agreement 
on the approach. If you like the approach, please let me know, and I'll follow 
up with tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to