vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks, lgtm!

In PR43614 I mentioned adding an extra argument to llvm-cov to specify the base 
directory. On second thought, the existing `-path-equivalence` option should 
make that unnecessary.



================
Comment at: clang/test/CoverageMapping/debug-dir.cpp:14
+//
+// RELATIVE: @__llvm_coverage_mapping = {{.*"\\01[^/]*foobar.*debug-dir\.cpp}}
+
----------------
Does the "[^/]" check work on Windows, or is something like "[^/\\]" necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68733/new/

https://reviews.llvm.org/D68733



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to