baloghadamsoftware added a comment.

In D62525#1609334 <https://reviews.llvm.org/D62525#1609334>, @NoQ wrote:

> Ok, so is it problematic to define a lambda that checks whether an 
> interesting iterator is invalidated? Or is it difficult to return the note 
> tag from many stack frames in order to finally squeeze it into the transition?


Both. The lambda can iterator through all the iterator positions, but how could 
it know which one was just invalidated? Or incremented, decremented, reached 
the first position or the past-the end position? We do not keep history. 
Returning note tags and passing them through all the functions called, 
combining them is a nightmare. It makes the code totally unreadable and I am 
not even sure how to do it correctly. Note tags are great, but here a 
conventional visitor fits better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62525/new/

https://reviews.llvm.org/D62525



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to