[PATCH] D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign

[Guillaume Chatelet via Phabricator via cfe-commits]

gchatelet marked 5 inline comments as done.
gchatelet added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:6323
     GV->setSection("__DATA, __objc_data");
-  GV->setAlignment(
-      CGM.getDataLayout().getABITypeAlignment(ObjCTypes.ClassnfABITy));
+  GV->setAlignment(llvm::Align(
+      CGM.getDataLayout().getABITypeAlignment(ObjCTypes.ClassnfABITy)));
----------------
courbet wrote:
> I don;t think `getABITypeAlignment` makes  any promisses on the return value.
It is, I posted a comment on the other patch 
https://reviews.llvm.org/D68268#inline-614898


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68274/new/

https://reviews.llvm.org/D68274



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits