mitchell-stellar marked 4 inline comments as done.
mitchell-stellar added inline comments.
================
Comment at: clang/lib/Format/Format.cpp:643
+ true};
switch (Style.BreakBeforeBraces) {
case FormatStyle::BS_Linux:
----------------
MyDeveloperDay wrote:
> Nit: this a drive by comment, but I feel this is really hard to read.. and
> not something that needs to be done in this revision but this feels like it
> needs to be formatted differently
>
> {
> /*AfterClass=*/false,
> /*AfterEnum=*/false
> /*AfterControlStatement=*/FormatStyle::BWACS_Never,
> .....
> }
>
> because without going back and checking that the AfterControl statement is
> the 3rd bool I simply can't see what is on and what is off.
I'm going to leave this as-is, because before, I was still forced to look-up
what each `true` or `false` value was assigned to.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68296/new/
https://reviews.llvm.org/D68296
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
