logan added a comment.
In general, it looks good to me if the comments are addressed.
Sorry for not replying responsively. Not sure why I missed the follow-up
e-mails after @rengolin's reply.
================
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
----------------
Since this is `unwind.h`, I feel that we can get a step further and use
`__ARM_EABI_UNWINDER__` to get more compatibility to GCC's unwind.h.
Here's the change:
```
#if defined(__arm__) && !defined(__USING_SJLJ_EXCEPTIONS__) && \
!defined(__ARM_DWARF_EH__)
#define __ARM_EABI_UNWINDER__ 1
#endif
```
================
Comment at: lib/Headers/unwind.h:89
@@ -81,1 +88,3 @@
_URC_NO_REASON = 0,
+#if _UNWIND_ARM_EHABI
+ _URC_OK = 0, /* used by ARM EHABI */
----------------
```
#ifdef __ARM_EABI_UNWINDER__
```
================
Comment at: lib/Headers/unwind.h:166
@@ -152,1 +165,3 @@
+#if _UNWIND_ARM_EHABI
+typedef uint32_t _Unwind_State;
----------------
```
#ifdef __ARM_EABI_UNWINDER__
```
http://reviews.llvm.org/D15883
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
