rsmith added a comment.

This seems reasonable to me, but a test case would be nice.

A mode to validate that header path changes don't change anything would be nice 
(essentially: redo all the header searches with the new set of paths and new 
filesystem and make sure they find the same thing), but doesn't seem urgent. 
(Note that that would catch both the case where the changed header search paths 
affect behavior and also the case where new files have appeared on an existing 
header search path and should be found by the header lookup instead of the 
cached ones.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67010/new/

https://reviews.llvm.org/D67010



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D67010: [... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D670... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to