tstellar marked an inline comment as done.
tstellar added inline comments.
================
Comment at: clang/test/Driver/modules.cpp:19
+// CHECK-COMPILE-SAME: {{ -o }}
+// CHECK-COMPILE-SAME: module{{2*}}.{{pcm.o|s}}
// CHECK-COMPILE-SAME: -x pcm
----------------
dyung wrote:
> I'm not sure what the regex module{{2*}} is supposed to match, or prevent
> from matching? Was this intentional?
>
> It seems it would match "module", "module2", "module22", "module222", etc.
> When would the compiler ever generate anything other than the first? Unless
> you are trying to protect yourself against a build directory that contains
> module in the name, but I'm not sure how this helps that...
This CHECK line is used by two different RUN lines, the first writes to
module.pcm.o and the second writes to module2.pcm.o.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66176/new/
https://reviews.llvm.org/D66176
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
