hokein marked an inline comment as done. hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:38 + "package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/";, + "publish": "vsce publish --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/"; }, ---------------- ilya-biryukov wrote: > Just to make sure I understand what's going on... > > Could you explain what `--baseImagesUrl` does? > The suggested url returns an error code when I try to load it in a browser. This is expected, this is a **base** url. it is used to assemble a full url with the screenshot links in the readme, an example is ` https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/` + `doc-assets/complete.png`, so that the screenshot can be rendered correctly in the VSCode market. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68080/new/ https://reviews.llvm.org/D68080 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
