svenvh marked an inline comment as done.
svenvh added inline comments.

================
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102
 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is 
invalid in OpenCL}}
+// expected-error@-3{{implicit conversion changes signedness: 'int' to 'uint' 
(aka 'unsigned int')}}
 #endif
----------------
Anastasia wrote:
> I am slightly confused about this error, isn't `get_sub_group_size` supposed 
> to return uint?
I think this is a side-effect from the previous error.  It failed to resolve 
`get_sub_group_size` so it inserted a placeholder declaration with return type 
`int`.  Does that make sense?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67714/new/

https://reviews.llvm.org/D67714



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to