ariccio added a comment.

Whoops, forgot to submit my earlier comments. Responding to comments right 
now...


================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
 import plistlib
-import CmpRuns
+import CmpRuns  # ?
 
----------------
This file imports itself?

I wasn't sure if I could eliminate this.

================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/SATestBuild.py:62
@@ -60,3 +61,3 @@
 
 def detectCPUs():
     """
----------------
Should this be replaced with `multiprocessing.cpu_count`?


http://reviews.llvm.org/D17253



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to