aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:56 + const auto *ID = Result.Nodes.getNodeAs<ObjCImplementationDecl>("impl"); + diag(ID->getLocation(), "%0 implements -isEqual: without implementing -hash") + << ID; ---------------- Do you think we could generate a fixit to add the `hash` method? Do you think we could even add a default implementation that returns the pointer to the object (assuming that's the correct default behavior)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67737/new/ https://reviews.llvm.org/D67737 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits