hfinkel added a comment. > One thought that occurs to me when reviewing this. I think we will assume > that F18 <https://reviews.llvm.org/F18>/flang when it lands in the LLVM > project will be an optional thing to build and will be an opt-in project at > the start that is off by default. What happens when clang --driver-mode=flang > is called and flang has not been built? And where would we put a test for > that behaviour? If flang were not to be built, should --driver-mode=flang be > unsupported/unrecognised and emit an error message?
The Clang tests should not actually run flang regardless - they should just test the command line that should be run. An error might be emitted if "flang" isn't found in the relevant search paths, however, that makes sense to me (although we might override this for the purpose of the tests?). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
