MyDeveloperDay added a comment. Thank you for this patch
This LGTM, ensure you comment out the failing unit tests and add a FIXME to the test as to why they don't currently work (or fix them if possible), the tests need to keep passing or others will not know they haven't broken things. Normally there always would be a comment saying please state a public style guide that uses a new style, but as Whitesmiths style is mentioned on the Wikipedia page about Indentation style so I would think you were good to add it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
