hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Thanks! looks good. I think next step is to implement it in the LSP layer. ================ Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:161 + )cpp"; + Annotations HeaderAnnotations(HeaderContents); + FS.Files[FooH] = HeaderAnnotations.code(); ---------------- nit: we can remove the annotation since we don't use it in the test, just ``` FS.Files[FooH] = R"cpp(...)cpp"; ``` ================ Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:163 + FS.Files[FooH] = HeaderAnnotations.code(); + Server.addDocument(FooH, HeaderAnnotations.code()); + ---------------- nit: we can get rid of this statement as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67650/new/ https://reviews.llvm.org/D67650 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
