mwyman added a comment. In D67567#1669866 <https://reviews.llvm.org/D67567#1669866>, @lebedev.ri wrote:
> 1. Please split each check into separate review. > 2. Is `dispatch_once_t` OSX-specific thing? Should those checks be in `osx` > module? 1. I split the review. 2. I don't see an `osx` module—am I somehow missing seeing it? `dispatch_once_t` is something from `libdispatch`which is an Apple-created API, but is OSS and available outside Apple. It's also a C API, which is why I didn't feel `objc` was an appropriate module either. I'm open to a better home module for this check, it's just not clear to me where that might be. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits