aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! Thank you for this refactoring -- it was large, but I think the results from it are really good. ================ Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:66-69 + unsigned AttrKind : 16; + /// Corresponds to the Syntax enum. + unsigned SyntaxUsed : 3; + unsigned SpellingIndex : 4; ---------------- erichkeane wrote: > aaron.ballman wrote: > > Do you want to do `= 0` here to give them in-class initializers? (well, > > `SpellingIndex` should probably be `SpellingNotCalculated`). > Bitfield in-class initializers are a C++2a feature. Details. Invent a time machine and add this to C++14. ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
