gribozavr requested changes to this revision.
gribozavr added inline comments.
This revision now requires changes to proceed.
================
Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:37
const cross_tu::CrossTranslationUnitContext &CTU);
-#include "clang/StaticAnalyzer/Core/Analyses.def"
+#include "clang/Analysis/PathDiagnosticConsumers.def"
----------------
Does this code declare e.g., createPlistDiagnosticConsumer? That function is
defined in libStaticAnalyzer. Declaring it libAnalysis is not appropriate, and
effectively introduces a layering violation. Users who link against libAnalysis
will get link errors if they don't link against libStaticAnalyzer.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67422/new/
https://reviews.llvm.org/D67422
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
