ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:748
+    llvm::StringRef CanonicalPath = Pair.second;
+    int Components = std::distance(llvm::sys::path::begin(Suffix),
+                                   llvm::sys::path::end(Suffix));
----------------
Note that `addSuffixMapping`/`findSuffixMapping` are not paired anymore, which 
I personally find to be odd.
But let me know whether that's a concern someone else shares.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67172/new/

https://reviews.llvm.org/D67172



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to