vsapsai marked 4 inline comments as done.
vsapsai added a comment.

Updated the code. Hope it is easier to understand now.



================
Comment at: clang/lib/Lex/HeaderSearch.cpp:908-909
 
+    if (IsMapped)
+      *IsMapped = CurrentInHeaderMap || HasBeenMapped;
+
----------------
dexonsmith wrote:
> Are you intentionally delaying this until after the `if (!File)` check?  If 
> so, why?
Agree it is non-obvious and error-prone when changing the code. Changed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58094/new/

https://reviews.llvm.org/D58094



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to