aaron.ballman added inline comments.
================ Comment at: clang/lib/Sema/SemaTemplate.cpp:727 return DependentScopeDeclRefExpr::Create( - Context, SS.getWithLocInContext(Context), TemplateKWLoc, NameInfo, - TemplateArgs); + Context, std::move(QualifierLoc), TemplateKWLoc, NameInfo, TemplateArgs); } ---------------- The call to `std::move()` shouldn't be necessary. ================ Comment at: clang/test/SemaTemplate/instantiate-incomplete-typo-suggested-error-limit.cpp:1 +// RUN: not %clang -fsyntax-only -std=c++11 -ferror-limit=1 %s 2>&1 | FileCheck %s + ---------------- Do you intend to test `%clang_cc1` instead? Can the test be rewritten to use `-verify` rather than `FileCheck`? If the test crashes or asserts, that will cause the test to fail anyway, so it doesn't seem like it needs to `FileCheck`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64644/new/ https://reviews.llvm.org/D64644 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
