sbenza added inline comments. ================ Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:644 @@ -643,2 +643,3 @@ explicit HasNameMatcher(StringRef Name); + explicit HasNameMatcher(ArrayRef<const StringRef *> Names); ---------------- alexfh wrote: > bkramer wrote: > > alexfh wrote: > > > Why not `ArrayRef<StringRef>`? > > That's an artifact of how llvm::VariadicFunction works. It gives you an > > array ref of pointers to the arguments. > Thanks! Good to know. Maybe a add a comment or is it just me who doesn't know > this? No reason to leak the VariadicFunction design into here. I moved the transformation into std::vector<> to the caller.
http://reviews.llvm.org/D17163 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
