broadwaylamb added a comment. In D66834#1652756 <https://reviews.llvm.org/D66834#1652756>, @compnerd wrote:
> I think that this is pretty easy to forget. Fortunately, last argument wins. > Why not sink this into the `%clang` substitution in lit? That ensures that > we run with an empty sysroot and then when the test needs to adjust the > sysroot, it can do so explicitly. This totally makes sense. I've just tried to do it, but unfortunately some tests are failing, for example, `Driver/cc1-response-files.c`. The problem is that `%clang` is expanded to `/path/to/clang --sysroot=`, but the succeeding flags (such as `-cc1`) may be incompatible with `--sysroot`. Or am I missing something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66834/new/ https://reviews.llvm.org/D66834 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
