hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
LGTM from my side. ================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:471 + case HighlightingKind::Macro: + return "entity.name.function.preprocessor.expansion.cpp"; case HighlightingKind::NumKinds: ---------------- I'd drop the expansion, just use `entity.name.function.preprocessor.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
