hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:38 Primitive, + LocalVariable, ---------------- ilya-biryukov wrote: > NIT: maybe put it right after `Variable`? IIUC, we do not rely on actual > numeric values being the same across different clangd versions. +1, related symbols should be grouped together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66723/new/ https://reviews.llvm.org/D66723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
