Mordante added inline comments.
================ Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics ---------------- comex wrote: > Mordante wrote: > > Wouldn't it be better to keep the original C++11 test and add a second > > `RUN:` for the C++14 test? > > Then guard the new test with `#if __cplusplus >= 201402L` > Perhaps, but most tests aren't run multiple times with different -std > options, and I didn't see any reason this test in particular needed that. > Maybe it should just be renamed to default-arguments-cxx14.cpp. I'm rather new here so I don't know what the renaming policy is, so I leave it to the more experienced reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66067/new/ https://reviews.llvm.org/D66067 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
