owenpan added inline comments.
================ Comment at: clang/lib/Format/TokenAnnotator.cpp:2618 + // using (FileStream fs... + if (Style.isCSharp() && Left.is(tok::kw_using) && Right.is(tok::l_paren)) + return true; ---------------- `if (Style.isCSharp() && Left.is(tok::kw_using))` would suffice as `Right.is(tok::l_paren)` is already checked on Line 2613. ================ Comment at: clang/unittests/Format/FormatTestCSharp.cpp:169 +TEST_F(FormatTestCSharp, CSharpUsing) { + verifyFormat("using (StreamWriter sw = new StreamWriter(filename) { }"); +} ---------------- Maybe set `SpaceBeforeParens` to `Always` first in order to really test the new behavior? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66662/new/ https://reviews.llvm.org/D66662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits