Szelethus added a comment. What I meant is that the diff has to be made against the master branch or I won't be able to apply it locally. Say your repo is structured like this:
* dcba2 (HEAD -> my_fix) * dcba1 * abcd4 (master) * abcd3 * abcd2 * abcd1 Then the diff has to be made with `git diff master -U99999 > my_fix.diff` and uploaded here, or with the use of arcanist (which I still find incredibly inconvenient). If you only upload the latest commit, I'd be missing `dcba1`. If you have a lot of changes you want to submit, like this: * hjkd2 (enable_feature_by_default) * hjkd1 * haha1 (my_feature) * dcba2 (HEAD -> my_fix) * dcba1 * abcd4 (master) You should create a revision for each branch, diff them against each other (`git checkout my_feature && git diff my_fix -U99999 > my_feature.diff`), and mark them as dependencies of each other on the right hand panel. It is kinda inconvenient, I'll admit :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
