xbolva00 added a comment.

I fixed and enabled this checker to warn for macros too.

@aaron.ballman is right. Yes, as he said... If the user has a time to add 
-Wno-xor.... to build systems, he/she has also time to improve code readability 
and use hexadecimal literals.

But I am a bit worried that the user does not realize that he/she could fix it 
using hexadecimal literals... Should this be part of silence note? (any 
proposed wording?) or add to Clang docs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66397/new/

https://reviews.llvm.org/D66397



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to