NoQ marked an inline comment as done. NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/CommonBugCategories.cpp:14-20 const char * const CoreFoundationObjectiveC = "Core Foundation/Objective-C"; const char * const LogicError = "Logic error"; const char * const MemoryRefCount = "Memory (Core Foundation/Objective-C/OSObject)"; const char * const MemoryError = "Memory error"; const char * const UnixAPI = "Unix API"; +const char * const CXXObjectLifecycle = "C++ object lifecycle"; ---------------- Szelethus wrote: > `static constexpr StringLiteral`? Why is there a need to have a header and a > cpp file for this? Not that it matters much (definitely not in the context of > this patch), but compile-time stuff is cool. Ancient stuff, i guess. We only have C++11 for like 3 years i think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
