NoQ marked an inline comment as done.
NoQ added inline comments.
================
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:347
+
+ virtual llvm::ArrayRef<FixItHint> getFixits() const { return Fixits; }
+
----------------
gribozavr wrote:
> Why is it virtual? In fact, why is BugReporter subclassable at all?
This clearly doesn't need to be virtual. I copy-pasted it from nearby functions
without applying any critical thinking.
However, BugReport(er) most likely needs to be sub-classable because
D66473#inline-596021, so i promise to clean those up in the process :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65182/new/
https://reviews.llvm.org/D65182
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
